PP-693 (partial): Switch to a new ULID library #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunommts
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This is a partial fix for PP-693. We were using a ULID library that can't work on old devices due to them missing the standard
java.timepackage.Why are we doing this? (w/ JIRA link if applicable)
Affects: https://ebce-lyrasis.atlassian.net/browse/PP-693
How should this be tested? / Do these changes have associated tests?
Unfortunately, the player still appears to be broken (and I'm debugging right now). This at least makes it slightly less broken.
Dependencies for merging? Releasing to production?
None.
Have you updated the changelog?
Not until the problem is actually fixed.
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@io7m Verified one of the problems went away.