PP-714: Make BottomNavigator bug non-fatal #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't attempt to pop the stack unless there's something to pop. Catch any NullPointerExceptions that the library might raise. Affects: https://ebce-lyrasis.atlassian.net/browse/PP-714
nunommts
suggested changes
Nov 10, 2023
...ui-navigation-tabs/src/main/java/org/librarysimplified/ui/navigation/tabs/TabbedNavigator.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Don't attempt to pop the stack unless there's something to pop.
Catch any NullPointerExceptions that the library might raise.
Why are we doing this? (w/ JIRA link if applicable)
Affects: https://ebce-lyrasis.atlassian.net/browse/PP-714
How should this be tested? / Do these changes have associated tests?
Nothing new. Just see if the crashes stop after
1.8.0...Dependencies for merging? Releasing to production?
None.
Have you updated the changelog?
Yes.
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@io7m Used the catalog for a while. I've not seen the original crash, so I just wanted to check that I didn't break the catalog.