PP-747: Make bookmark syncing a purely client-side option #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunommts
approved these changes
Nov 21, 2023
|
Got to leave this un-merged for now. It'll break things as the server side's not ready. |
|
Server side was just deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This removes all code relating to the server-side bookmarks setting, and moves to having the on/off switch be purely local state.
Why are we doing this? (w/ JIRA link if applicable)
Fix: https://ebce-lyrasis.atlassian.net/browse/PP-747
How should this be tested? / Do these changes have associated tests?
Check that no bookmarks are logged if the switch is off. Check that they are if the switch is on.
Note that this will currently "fail" on real servers (sending bookmarks will probably receive a 403). This depends on a server-side change to work fully.
Dependencies for merging? Releasing to production?
Yes, we can't release this until the server-side work is done.
Have you updated the changelog?
Yes
Has the application documentation been updated for these changes?
Yes
Did someone actually run this code to verify it works?
@io7m Tried it!