Return a more appropriate error from DSOAL_DirectSoundCreate8

ThreeDeeJay · Apr 13, 2023 · dcaa78b · dcaa78b
1 parent 1ba60c3
commit dcaa78b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/dsoal.cpp b/src/dsoal.cpp
@@ -296,20 +296,21 @@ HRESULT WINAPI DSOAL_DirectSoundCreate8(const GUID *deviceId, IDirectSound8 **ds
         return DSERR_INVALIDPARAM;
     }
 
+    HRESULT hr{};
     try {
         auto dsobj = DSound8OAL::Create();
-        HRESULT hr{dsobj->Initialize(deviceId)};
+        hr = dsobj->Initialize(deviceId);
         if(SUCCEEDED(hr))
         {
             *ds = dsobj.release()->as<IDirectSound8*>();
             return DS_OK;
         }
     }
     catch(std::bad_alloc&) {
-        return DSERR_OUTOFMEMORY;
+        hr = DSERR_OUTOFMEMORY;
     }
 
-    return E_NOTIMPL;
+    return hr;
 }
 
 HRESULT WINAPI DSOAL_DirectSoundCaptureCreate(const GUID *deviceId, IDirectSoundCapture **ds,