Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat: Improve ScoreAnalysis debug information #102

Closed
wants to merge 1 commit into from
Closed

feat: Improve ScoreAnalysis debug information #102

wants to merge 1 commit into from

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jun 28, 2024

This pull request adds a summary logic to the ScoreAnalysis.

@zepfred zepfred requested a review from triceo June 28, 2024 22:09
@zepfred zepfred force-pushed the score-analysis-print branch from 537b5f0 to edc23d0 Compare June 28, 2024 22:10
@triceo triceo requested review from Christopher-Chianelli and removed request for triceo July 1, 2024 05:55
triceo
triceo reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding a test method to make sure that the methods on the Java type match the methods on the Python type.

See test_has_all_methods() in other tests. (Preferrably from #94, where I improved that method.)

@zepfred zepfred linked an issue Jul 1, 2024 that may be closed by this pull request
print(ScoreAnalysis): make it easy to analyze a score during POC #76
Closed
@zepfred zepfred closed this Jul 1, 2024
@zepfred zepfred deleted the score-analysis-print branch July 1, 2024 14:05
@zepfred zepfred mentioned this pull request Jul 2, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@triceo triceo triceo left review comments

@Christopher-Chianelli Christopher-Chianelli Awaiting requested review from Christopher-Chianelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print(ScoreAnalysis): make it easy to analyze a score during POC
2 participants
@zepfred @triceo