This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
chore: Refactor how Opcodes are created/lookup #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Christopher-Chianelli
commented
Mar 13, 2024
Christopher-Chianelli
commented
- PythonBytecodeInstruction becomes a record
- Removed the 200+ constants OpcodeIdentifier enum and replaced with a sealed interface OpcodeDescriptor, this allows the enum to be split across several classes (and for many switches to be total without a default branch).
- Replace opcode lookup switches with a method call on the new OpcodeDescriptor class
- PythonBytecodeInstruction becomes a record - Removed the 200+ constants OpcodeIdentifier enum and replaced with a sealed interface OpcodeDescriptor, this allows the enum to be split across several classes (and for many switches to be total without a default branch). - Replace opcode lookup switches with a method call on the new OpcodeDescriptor class - testGeneratorWithTryExcept is failing, but no other tests fail. This make me suspect there a bug with the rewritten PythonFunctionBuilder or ExceptBuilder that is used exclusively in tests.
… early Previously, PythonBytecodeInstruction was mutable. This meant that the test function builder can pass the except builder a dummy instruction for the try goto when its exit early. PythonBytecodeInstruction is now immutable, which means to update the instruction, you must replace it in the list. This causes issues when the dummy instruction is used, since the dummy instruction will replace a real instruction. The test function builder will now pass null instead of a dummy instruction, which except builder need to check before updating the list.
triceo
approved these changes
Mar 13, 2024
jpyinterpreter/src/main/java/ai/timefold/jpyinterpreter/PythonBytecodeInstruction.java
Outdated
Show resolved
Hide resolved
jpyinterpreter/src/main/java/ai/timefold/jpyinterpreter/PythonCompiledFunction.java
Outdated
Show resolved
Hide resolved
jpyinterpreter/src/main/java/ai/timefold/jpyinterpreter/PythonVersion.java
Show resolved
Hide resolved
...terpreter/src/main/java/ai/timefold/jpyinterpreter/opcodes/descriptor/AsyncOpDescriptor.java
Show resolved
Hide resolved
...preter/src/main/java/ai/timefold/jpyinterpreter/opcodes/descriptor/VariableOpDescriptor.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.