This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
feat: Add support for problem changes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceo
reviewed
Apr 16, 2024
triceo
approved these changes
Apr 16, 2024
- Since the methods in ProblemChangeDirector take interfaces, ProblemChange as a whole cannot be translated to pure Java (since that requires supporting casting an arbitary callable to any Java interface, which is not suported yet (nor planned to be supported)). - Thus we goes for a more ugly approach: the ProblemChange runs in Python, and when a problem change director method is called, we compile/translate the supplied function to Java. - We do a trick where we replace the Python working solution clone with the actual Java working solution in the closure before compiling the function so changes are applied to the right object. After the method is called, we then update the Python working solution from the java working solution so changes are reflected in it too. - Use implement a ProblemChange by extending an abstract base class (which, among other things, raises an error if not all of its methods are implemented).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the methods in ProblemChangeDirector take interfaces, ProblemChange as a whole cannot be translated to pure Java (since that requires supporting casting an arbitary callable to any Java interface, which is not suported yet (nor planned to be supported)).
Thus we goes for a more ugly approach: the ProblemChange runs in Python, and when a problem change director method is called, we compile/translate the supplied function to Java.
We do a trick where we replace the Python working solution clone with the actual Java working solution in the closure before compiling the function so changes are applied to the right object. After the method is called, we then update the Python working solution from the java working solution so changes are reflected in it too.
Users implement a ProblemChange by extending an abstract base class (which, among other things, raises an error if not all of its methods are implemented).