This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
chore: Remove Java type stubs from default build, rename jpyinterpreter to _jpyinterpreter #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to _jpyinterpreter - Having the Java type stubs in the default build meant that IDE's will see two definitions of the same class (one from `ai.timefold.solver` (the Java one) and one from `timefold.solver` (the Python one)). Since users should only interact with the Python classes, the Java type stubs should not be included. - Rename jpyinterpreter to _jpyinterpreter since it is a private package and not public API - Fix link and packages used in the README
triceo
approved these changes
May 15, 2024
Co-authored-by: Lukáš Petrovický <lukas@petrovicky.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the Java type stubs in the default build meant that IDE's will see two definitions of the same class (one from
ai.timefold.solver(the Java one) and one fromtimefold.solver(the Python one)). Since users should only interact with the Python classes, the Java type stubs should not be included.Rename jpyinterpreter to _jpyinterpreter since it is a private package and not public API
Fix link and packages used in the README