-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Diversified Late Acceptance approach #1253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation.
In the docs, take inspiration from the late acceptance selector; remember to reference the paper, give a brief description of the difference between LA and this.
Also search for "preview" in the existing docs, and make sure to mark the feature as a preview the same way we do elsewhere.
core/src/main/java/ai/timefold/solver/core/config/solver/SolverConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/config/solver/SolverConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/config/solver/SolverConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/HeuristicConfigPolicy.java
Outdated
Show resolved
Hide resolved
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
core/src/test/java/ai/timefold/solver/core/impl/heuristic/HeuristicConfigPolicyTestUtils.java
Outdated
Show resolved
Hide resolved
The Spring failure will require a change to this, I think: |
docs/src/modules/ROOT/pages/optimization-algorithms/local-search.adoc
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/HeuristicConfigPolicy.java
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/optimization-algorithms/local-search.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments, then LGTM.
Not sure why Enterprise is failing. Intermittent failure? |
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
...core/impl/localsearch/decider/acceptor/lateacceptance/DiversifiedLateAcceptanceAcceptor.java
Outdated
Show resolved
Hide resolved
It is also failing locally, and I'm investigating it. |
Quality Gate passedIssues Measures |
@zepfred Sonar says there are unnecessary casts in the PR. Can you please double-check? (Sometimes it's a false positive, in which case I'll merge this right away.) |
It is a false positive. |
This PR adds a new acceptor approach: Diversified Late Acceptance approach (DLAS). The implementation is based on the work:
Diversified Late Acceptance Search by M. Namazi, C. Sanderson, M. A. H. Newton, M. M. A. Polash, and A. Sattar