Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Diversified Late Acceptance approach #1253

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Dec 5, 2024

This PR adds a new acceptor approach: Diversified Late Acceptance approach (DLAS). The implementation is based on the work:

Diversified Late Acceptance Search by M. Namazi, C. Sanderson, M. A. H. Newton, M. M. A. Polash, and A. Sattar

Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation.

In the docs, take inspiration from the late acceptance selector; remember to reference the paper, give a brief description of the difference between LA and this.

Also search for "preview" in the existing docs, and make sure to mark the feature as a preview the same way we do elsewhere.

Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments, then LGTM.

@triceo
Copy link
Contributor

triceo commented Dec 6, 2024

Not sure why Enterprise is failing. Intermittent failure?

@triceo triceo added this to the 1.17.0 milestone Dec 6, 2024
@zepfred
Copy link
Contributor Author

zepfred commented Dec 6, 2024

Not sure why Enterprise is failing. Intermittent failure?

It is also failing locally, and I'm investigating it.

@triceo
Copy link
Contributor

triceo commented Dec 6, 2024

@zepfred Sonar says there are unnecessary casts in the PR. Can you please double-check? (Sometimes it's a false positive, in which case I'll merge this right away.)

@zepfred
Copy link
Contributor Author

zepfred commented Dec 6, 2024

@zepfred Sonar says there are unnecessary casts in the PR. Can you please double-check? (Sometimes it's a false positive, in which case I'll merge this right away.)

It is a false positive.

@triceo triceo merged commit c6c30e9 into TimefoldAI:main Dec 6, 2024
28 checks passed
@zepfred zepfred deleted the add-dlas branch December 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants