Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce the LocationInList allocation rate #1277

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Dec 16, 2024

Although the actual move evaluation speed increase is small (~ 3 %), the allocation rate drops substantially.

Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar complains about insufficient coverage of the new code. It's true that I haven't noticed a new tests being added for the ListVariableSupply.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
58.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@triceo triceo merged commit 415de75 into TimefoldAI:main Dec 17, 2024
27 of 28 checks passed
@triceo triceo deleted the lessmem branch December 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants