feat: Add concat operation to constraint streams #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Chianelli
force-pushed
the
cs-concat
branch
from
cbdb6a4 to
25ae30e
Compare
triceo
reviewed
Sep 30, 2023
...src/main/java/ai/timefold/solver/constraint/streams/bavet/BavetConstraintSessionFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/ai/timefold/solver/constraint/streams/bavet/bi/BavetAbstractBiConstraintStream.java
Outdated
Show resolved
Hide resolved
...-streams/src/main/java/ai/timefold/solver/constraint/streams/bavet/bi/BavetBiConcatNode.java
Show resolved
Hide resolved
...ams/src/main/java/ai/timefold/solver/constraint/streams/bavet/common/AbstractConcatNode.java
Outdated
Show resolved
Hide resolved
...ams/src/main/java/ai/timefold/solver/constraint/streams/bavet/common/AbstractConcatNode.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Sep 30, 2023
...ams/src/main/java/ai/timefold/solver/constraint/streams/bavet/common/AbstractConcatNode.java
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
force-pushed
the
cs-concat
branch
from
854717d to
d2ddc19
Compare
triceo
reviewed
Oct 10, 2023
...ain/java/ai/timefold/solver/constraint/streams/bavet/uni/BavetConcatUniConstraintStream.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Oct 10, 2023
...src/main/java/ai/timefold/solver/constraint/streams/bavet/BavetConstraintSessionFactory.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Oct 10, 2023
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Oct 10, 2023
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Oct 10, 2023
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Oct 10, 2023
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
|
DONE: change text in image to use |
The concat operation acts as an or between two constraint streams, propogating both stream tuples' downstream. It appears update/retract may be called before an insert, meaning the out tuple stored inside the in tuple is not set. As such, for update, if the out tuple is not set, it does an insert instead, and for retract, it simply ignores the operation.
Concat is more similar to UNION ALL than OR.
Co-authored-by: Lukáš Petrovický <lukas@petrovicky.net>
Christopher-Chianelli
force-pushed
the
cs-concat
branch
from
61521ac to
ce67093
Compare
…ing layer index for binary operations
This also removes the "minimumNumberOfAssignmentsNoAssignments" constraint since "minimumAndMaximumNumberOfAssignments" now handles that case.
triceo
approved these changes
Oct 11, 2023
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/constraints-and-score.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukáš Petrovický <lukas@petrovicky.net>
Previously, concat did not update the content of the cloned tuples in update. The `groupBy` and `map` building blocks both modify the contents of their tuples instead of creating new ones. As a result, concat was passing stale tuples with incorrect content downstream when placed after a `groupBy` or `map` building block. Now, the contents of the tuples are updated in update to prevent this issue. Co-authored-by: Lukáš Petrovický <lukas@petrovicky.net>
triceo
reviewed
Oct 11, 2023
...-streams/src/main/java/ai/timefold/solver/constraint/streams/bavet/bi/BavetBiConcatNode.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concat operation acts as an or between two constraint streams, propogating both stream tuples' downstream. It appears update/retract may be called before an insert, meaning the out tuple stored inside the in tuple is not set. As such, for update, if the out tuple is not set, it does an insert instead, and for retract, it simply ignores the operation.