Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve support for Java records #308

Merged
merged 10 commits into from
Oct 9, 2023
Merged

feat: improve support for Java records #308

merged 10 commits into from
Oct 9, 2023

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Oct 8, 2023 •
edited
Loading

Does several things:

  1. Records can serve as planning variables; planning ID annotation on record components no longer throws.
  2. Records can no longer be solutions or entities, as these need to be mutable.
  3. Records are no longer deep-cloned, receiving the same treatment as enums.
  4. Throws a better exception when cloning fails due to an exception in constructor.

The second and third change are technically backwards incompatible behavior but we introduce it anyway, as the old behavior was erroneous.

@triceo triceo linked an issue Oct 8, 2023 that may be closed by this pull request
Misleading error message when cloning fails to create a new instance #271
Closed
@triceo triceo requested a review from rsynek October 8, 2023 09:07
@triceo triceo added this to the 1.3.0 milestone Oct 8, 2023
rsynek
rsynek approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

core/core-impl/src/main/java/ai/timefold/solver/core/config/util/ConfigUtils.java Outdated Show resolved Hide resolved
@triceo triceo merged commit 2c56079 into TimefoldAI:main Oct 9, 2023
9 checks passed
@triceo triceo deleted the records branch October 9, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsynek rsynek rsynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Misleading error message when cloning fails to create a new instance
2 participants
@triceo @rsynek