Change (V/H)Stack implementation from grid to flex #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's interesting to me that this works with the ZStack... I thought I had applied the same changes from grid syntax to flex syntax and then added minimum heights and widths to 0, but either I for some reason never tested it with this configuration or you have something special that I missed! Either way, I'm really glad to see this finally completed and I'm glad we're moving forward on this! Thanks! As I'm looking at this now, it seems that you're also failing the testMaterial visual test. I'm on my phone and can't currently look at test screenshots, but if someone could post them that would be great. |
carson-katri
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed @SwiftCoderJoe conversion of (V/H)Stack from grid to flex (PR #466).
As @SwiftCoderJoe mentioned in his PR, this change should fix the Spacer issues described in #441.
All relevant tests have been updated. I will circle back around and back fill with more (V/H)Stack tests.