Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone and localtime mounts to docker-compose #892

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

perfectra1n
Copy link
Contributor

No description provided.

Copy link
Contributor

@meichthys meichthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pano9000
Copy link
Contributor

pano9000 commented Jan 6, 2025

will this not cause issues on e.g. Windows Environments, where there is no /etc/timezone?

@perfectra1n
Copy link
Contributor Author

perfectra1n commented Jan 7, 2025

@pano9000 because of the line right above it:

- ${TRILIUM_DATA_DIR:-~/trilium-data}:/home/node/trilium-data

The Docker compose is already "not compatible" with Windows.

However, Docker on Windows currently leverages WSL2, which means that the Docker runtime runs on Linux. Docker doesn't run on native Windows.

@pano9000
Copy link
Contributor

pano9000 commented Jan 7, 2025

yeah, you are right, I had totally forgotten about WSL on Windows :-)
in other words: Kindly ignore my comment above :-) Sorry about that, but thanks for clarifying!

@eliandoran eliandoran merged commit c80299e into develop Jan 7, 2025
4 checks passed
@eliandoran eliandoran deleted the perfectra1n-patch-2 branch January 7, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants