Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra doctest filters #769

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Remove extra doctest filters #769

merged 1 commit into from
Jan 3, 2025

Conversation

penelopeysm
Copy link
Member

Closes #768

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (6657441) to head (fd50f7b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          36       36           
  Lines        4325     4325           
=======================================
  Hits         3722     3722           
  Misses        603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 21, 2024

Pull Request Test Coverage Report for Build 12448175843

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2830 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-82.2%) to 3.966%

Files with Coverage Reduction New Missed Lines %
src/selector.jl 5 0.0%
src/varname.jl 6 0.0%
src/test_utils/model_interface.jl 7 0.0%
src/model_utils.jl 11 0.0%
src/test_utils/contexts.jl 12 0.0%
src/distribution_wrappers.jl 13 0.0%
src/test_utils/varinfo.jl 23 0.0%
src/logdensityfunction.jl 23 0.0%
src/submodel_macro.jl 26 0.0%
src/extract_priors.jl 30 0.0%
Totals Coverage Status
Change from base Build 12436748831: -82.2%
Covered Lines: 166
Relevant Lines: 4186

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2024

Pull Request Test Coverage Report for Build 12454915025

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.137%

Totals Coverage Status
Change from base Build 12436748831: 0.0%
Covered Lines: 3722
Relevant Lines: 4321

💛 - Coveralls

@sunxd3
Copy link
Member

sunxd3 commented Dec 22, 2024

does this mean the code you removed do absolutely nothing?

@penelopeysm
Copy link
Member Author

@sunxd3 Sort of – in fact I'd say it was worse than nothing, as it obscured the incorrect doctest in src/varnamedvector.jl.

@yebai yebai requested a review from sunxd3 January 3, 2025 11:29
@penelopeysm
Copy link
Member Author

Thanks!

@penelopeysm penelopeysm added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit b7fd9ea Jan 3, 2025
20 checks passed
@penelopeysm penelopeysm deleted the py/doctests branch January 3, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unneeded doctest filters and fix tests
3 participants