Improve compilesim.py test coverage #458
Open
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #458 +/- ##
=============================================
+ Coverage 91.4% 91.7% +0.4%
=============================================
Files 24 24
Lines 6413 6413
=============================================
+ Hits 5858 5878 +20
+ Misses 555 535 -20 ☔ View full report in Codecov by Sentry. |
fdxmw
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Thank you for the pull request, looks good overall! I have some minor style comments, and there are a couple pycodestyle errors in the presubmit checks too:
tests/test_compilesim.py:948:1: W293 blank line contains whitespace
tests/test_compilesim.py:951:1: W293 blank line contains whitespace
|
@fdxmw fixed |
fdxmw
reviewed
Jan 6, 2025
| @@ -966,6 +990,18 @@ def rom_data_function(add): | |||
| ("o2", lambda x: rom_data_function(2 * x))), 6) | |||
| self.compareIO(self.sim_trace, exp_out) | |||
|
|
|||
| def test_function_rom_block_with_optimization_bidwidth_4(self): | |||
There was a problem hiding this comment.
Sorry but there are still bidwidths in the names of these four tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more tests to improve the test coverage of
compilesim.py:test_less_than_cmp_simulationandtest_equals_simulationto cover functions_build_eqand_build_cmpincompilesim.py_romwidthincompilesim.pytest_rom_romblock_in_memory_value_map_errorto test the exceptionraise PyrtlError('RomBlock in memory_value_map')(line 781 incompilesim.py)