Use the scripts without model-viewer as the exported ones #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoever uses this package via npm can also run `npm i model-viewer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, the inclusion of the model-viewer is needed for whoever includes the script from a CDN.
Correspondingly, they do not care what NPM considers to be the exports.
Conversely, people installing this package from NPM (such as myself) may prefer to install the
model-viewerthemselves.That's why in this PR I suggest to keep doing what you introduced with the two distributed JavaScript files, but this time declare the one without the model-viewer as the exported one.