Adjustments to Advent of Code #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49Indium
changed the title
49Indium
added
the
infra-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of two parts (that could have been separate PRs but are related).
Firstly, better error are now given session token expires. If the session token expires, the leaderboard page redirects to the advent home page (with a successful 200 response code) so the bot fails to read this as python. If we block redirects, we can detect this earlier and provide a better error message.
Secondly, AOC registrations did not persist between years. By removing the year in the registrations table, registrations will persist between years. Not that this will also require access to the database to remove this column. PLEASE DON'T MERGE until this is done. Once reviewed, I am happy to do this.