Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with .NET 6 to .NET 9 and use min versions of dependent packages #279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

frogcrush
Copy link

Allows targeting .NET 6 through .NET 9 using the same NuGet package. This is nice for me as some projects are using .NET 8 for LTS and some are on .NET 9.

@Arash-Sabet
Copy link
Contributor

Allows targeting .NET 6 through .NET 9 using the same NuGet package. This is nice for me as some projects are using .NET 8 for LTS and some are on .NET 9.

Thanks for opening the PR @frogcrush. I think it makes sense. Please give me a couple of days to review, test and merge.

@Arash-Sabet Arash-Sabet self-requested a review December 10, 2024 02:09
@Arash-Sabet Arash-Sabet added the enhancement New feature or request label Dec 10, 2024
@Arash-Sabet
Copy link
Contributor

@frogcrush I just had a chance to glance your changes. This is what I am getting:

image

How to resolve such warnings?

@frogcrush
Copy link
Author

Hey, I'm pretty sure that is because to target .NET 6, it uses Microsoft.Extensions.* version 6, .NET 7 uses V7, etc. as say V9 is not tested against .NET 6 and you will get compiler warnings.

If you manage packages for only the test project, you will correctly see that no package updates are available, as NuGet will select the correct version of dependent libraries.

@Arash-Sabet
Copy link
Contributor

@frogcrush Thanks for your inputs. I'd rather a flawless compile. Can we possibly get rid of .NET 6.0 at all as it's getting closer to its end of lifecycle?

@Arash-Sabet
Copy link
Contributor

@frogcrush Can you please suggest a plan to test the produced NuGet libraries before deploying to NuGet? How will the end up in NuGet? I have a limited time and I prefer not to enter into any significant challenges in undoing the changes or taking care of broken code in the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants