Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a seed to variant utils murmur hashing to fix variant distri… #171

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

daveleek
Copy link
Collaborator

@daveleek daveleek commented Oct 30, 2023

What

Uses a new seed for ensuring a fair distrbution for variants.

Background

After a customer reported that variant distribution seemed skewed we performed some testing and found that since we use the same hash string for both gradual rollout and variant allocation we'd reduced the set of groups we could get to whatever percentage our gradual rollout was set.

Example

Take a gradualRollout of 10%, this will select normalized hashes between 1 and 10, when we then again hash the same string that gave us between 1 and 10, but with modulo 1000 for variants, this will only give us 100 possible groups, instead of the expected 1000.

Fix

Force the normalization to accept a seed, and make sure to use a new seed when normalizing the variant distribution hash.

Worth noting

This will require release 4.0.0, since we're changing the signature of public methods.

Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, defaulting to zero is more of a cosmetic but might be a nice addition

@daveleek daveleek merged commit cccf3ef into main Oct 31, 2023
2 checks passed
@daveleek daveleek deleted the task/useDifferentSeedForVariantNormalization branch October 31, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants