feat: make sure gpg entry expects passphrase in environment variable (#…

…213) * Make sure the maven build also knows about the github token environment variable
Unleash · Sep 5, 2023 · 00442ef · 00442ef
1 parent 6c04e90
commit 00442ef
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/release_to_central.yml b/.github/workflows/release_to_central.yml
@@ -33,6 +33,7 @@ jobs:
       - name: Release
         run: mvn -B -DreleaseVersion=${{ inputs.version}} release:prepare release:perform
         env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}

diff --git a/.gitignore b/.gitignore
@@ -44,3 +44,4 @@ target
 
 .DS_Store
 **/bin/
+.vim/
diff --git a/pom.xml b/pom.xml
@@ -49,9 +49,8 @@
 
     <scm>
         <url>https://github.com/Unleash/unleash-client-java</url>
-        <connection>scm:git:git@github.com:Unleash/unleash-client-java.git</connection>
-        <developerConnection>scm:git:git@github.com:Unleash/unleash-client-java.git</developerConnection>
-        <tag>unleash-client-java-8.3.1</tag>
+        <connection>scm:git:https://github.com/Unleash/unleash-client-java.git</connection>
+        <developerConnection>scm:git:https://github.com/Unleash/unleash-client-java.git</developerConnection>
     </scm>
 
     <dependencies>
@@ -464,7 +463,7 @@
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-gpg-plugin</artifactId>
-                        <version>1.6</version>
+                        <version>3.1.0</version>
                         <executions>
                             <execution>
                                 <id>sign-artifacts</id>
@@ -473,7 +472,13 @@
                                     <goal>sign</goal>
                                 </goals>
                             </execution>
-                        </executions>
+                          </executions>
+                          <configuration>
+                            <gpgArguments>
+                              <arg>--pinentry-mode</arg>
+                              <arg>loopback</arg>
+                            </gpgArguments>
+                          </configuration>
                     </plugin>
                 </plugins>