Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added new metadata fields to Registration and Metrics #244

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat: Added new metadata fields to Registration and Metrics #244

merged 2 commits into from
Jul 25, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jul 25, 2024 •
edited
Loading

@chriswk chriswk requested a review from sighphyre July 25, 2024 09:16
@chriswk chriswk self-assigned this Jul 25, 2024
@chriswk
Copy link
Member Author

chriswk commented Jul 25, 2024

Running with experimental metrics and testing this change
client_sdk_versions{sdk_name="unleash-client-java",sdk_version="9.2.3-SNAPSHOT",platform_name="OpenJDK 64-Bit Server VM",platform_version="17.0.11+9",yggdrasil_version="not-set",spec_version="5.1.5"} 1

sighphyre
sighphyre approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriswk chriswk merged commit fcbc319 into main Jul 25, 2024
4 checks passed
@chriswk chriswk deleted the task/newMetrics branch July 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees

@chriswk chriswk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriswk @sighphyre