feat: log warning if there is diff between client/features and delta api #9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@sjaanus, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
chriswk,
FredrikOseberg,
gastonfournier and
ivarconr
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
reviewed
Jan 2, 2025
| await this.clientFeatureToggleService.getClientDelta( | ||
| undefined, | ||
| query!, | ||
| const delta = |
There was a problem hiding this comment.
do you want to run this sequentially or in parallel with the query you compare it against?
kwasniew
reviewed
Jan 2, 2025
| ); | ||
|
|
||
| const deepEqualIgnoreOrder = (obj1, obj2) => { |
There was a problem hiding this comment.
this is a pure function that can live outside of the class and doesn't need to be initialized on each HTTP request
kwasniew
approved these changes
Jan 2, 2025
kwasniew
reviewed
Jan 2, 2025
| @@ -407,4 +399,14 @@ export default class FeatureController extends Controller { | |||
| const jsonString = JSON.stringify(value); | |||
| return Buffer.byteLength(jsonString, 'utf8'); | |||
| } | |||
|
|
|||
| deepEqualIgnoreOrder = (obj1, obj2) => { | |||
There was a problem hiding this comment.
types seem to be missing here and this function doesn't need to be attached to class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log out the diff and warn if there is gap between old logic and new delta.