Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: 署名ではなくvoicevox_onnxruntimeproductionを使う #57

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 25, 2024

内容

この辺の区分けがよくわかっていませんが、今voicevox_onnxruntimeのビルド自体にproductionを使っているのでこうしようかと。

関連 Issue

スクリーンショット・動画など

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

コード署名する場合はtarget=voicevox_onnxruntimeにしないといけない感じになりますが、そもそもコード署名はこの条件じゃないとやらないと思うので良さそう!

@qryxip qryxip merged commit d146e81 into VOICEVOX:main Dec 25, 2024
2 checks passed
@qryxip qryxip deleted the feat-use-production-env-for-voicevox-onnxruntime branch December 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants