chore: voicevox_onnxruntime関係のログをすべてまとめてartifact化 #65
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| - name: Encrypt log | ||
| if: | | ||
| failure() | ||
| && ( | ||
| steps.switch-to-production.outcome == 'failure' | ||
| || steps.prepare.outcome == 'failure' | ||
| || steps.build.outcome == 'failure' | ||
| || steps.inspect-build-dir.outcome == 'failure' | ||
| ) | ||
| && env.TARGET_LIBRARY == 'voicevox_onnxruntime' | ||
| run: | | ||
| for file in ./${{ matrix.artifact_name }}_{stdout,stderr}.txt; do | ||
| gpg -ef ./builder/log-encryption-pub.asc "$file" | ||
| done | ||
|
|
||
| - name: Upload the encrypted log | ||
| if: | | ||
| failure() | ||
| && ( | ||
| steps.switch-to-production.outcome == 'failure' | ||
| || steps.prepare.outcome == 'failure' | ||
| || steps.build.outcome == 'failure' | ||
| || steps.inspect-build-dir.outcome == 'failure' | ||
| ) | ||
| && env.TARGET_LIBRARY == 'voicevox_onnxruntime' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: log_${{ matrix.artifact_name }} | ||
| path: ${{ matrix.artifact_name }}_*.txt.gpg |
There was a problem hiding this comment.
ifの中はfailure()とenv.TARGET_LIBRARY == 'voicevox_onnxruntime'だけにしたほうがid足し忘れとかで困らなくてメンテしやすいかも･･･？
あいや、voicevox_onnxruntimeだったら常にアップロードする形でも良い気がしました！
まあでもとりあえずそのままでも動くと思うのでマージでも良さそう！
There was a problem hiding this comment.
もう１回見て同じこと思いました！
まあたぶんvoicevox_onnxruntimeのときは常にアップロードする形がメンテナンス性高くて実装もスリムそう！
（重いとかない限り）
まあそれでもなお変更必須ではなさそう！
There was a problem hiding this comment.
ですね。あと成功したビルドのログも見たくなるときがあるかも。まあ別PRでですね。
|
|
qryxip
force-pushed
the
chore-export-all-voicevox-onnxruntime-related-log
branch
4 times, most recently
from
a38950d to
0a24d97
Compare
qryxip
force-pushed
the
chore-export-all-voicevox-onnxruntime-related-log
branch
from
0a24d97 to
7ca1122
Compare
|
以下の変更を加えました。お手数なのですがそこそこ大きいのでご確認願えますでしょうか。
voicevox_onnxruntimeでのビルド: |
| - name: Encrypt log | ||
| if: | | ||
| failure() | ||
| && ( | ||
| steps.switch-to-production.outcome == 'failure' | ||
| || steps.prepare.outcome == 'failure' | ||
| || steps.build.outcome == 'failure' | ||
| || steps.inspect-build-dir.outcome == 'failure' | ||
| ) | ||
| && env.TARGET_LIBRARY == 'voicevox_onnxruntime' | ||
| run: | | ||
| for file in ./${{ matrix.artifact_name }}_{stdout,stderr}.txt; do | ||
| gpg -ef ./builder/log-encryption-pub.asc "$file" | ||
| done | ||
|
|
||
| - name: Upload the encrypted log | ||
| if: | | ||
| failure() | ||
| && ( | ||
| steps.switch-to-production.outcome == 'failure' | ||
| || steps.prepare.outcome == 'failure' | ||
| || steps.build.outcome == 'failure' | ||
| || steps.inspect-build-dir.outcome == 'failure' | ||
| ) | ||
| && env.TARGET_LIBRARY == 'voicevox_onnxruntime' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: log_${{ matrix.artifact_name }} | ||
| path: ${{ matrix.artifact_name }}_*.txt.gpg |
There was a problem hiding this comment.
もう１回見て同じこと思いました！
まあたぶんvoicevox_onnxruntimeのときは常にアップロードする形がメンテナンス性高くて実装もスリムそう！
（重いとかない限り）
まあそれでもなお変更必須ではなさそう！
内容
voicevox_onnxruntimeに関係する次の4つのステップのログを、apeendしてひとまとめにしてartifact化するようにする。
checkouttree(1)関連 Issue
Refs: VOICEVOX/voicevox_project#24, #62 (comment)
スクリーンショット・動画など
その他