Improve: アップロード後にコメントを更新するようにする #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/common.ts
Outdated
| // 収集対象のリポジトリ | ||
| export const guestRepo = "voicevox/voicevox"; | ||
| // デプロイ情報を書き込むコメントの最初に付けるマーカー | ||
| export const commentMarker = "<!-- voiccevox preview-pages info -->"; |
There was a problem hiding this comment.
The word "voiccevox" should be "voicevox".
Suggested change
| export const commentMarker = "<!-- voiccevox preview-pages info -->"; | |
| export const commentMarker = "<!-- voicevox preview-pages info -->"; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Hiroshiba
approved these changes
Nov 23, 2024
| // 過去に使われていたマーカーも含めたマーカーの一覧 | ||
| export const commentMarkers = [ | ||
| commentMarker, | ||
| "<!-- voiccevox preview-pages info -->", |
There was a problem hiding this comment.
There is a typo in the comment marker. It should be "".
Suggested change
| "<!-- voiccevox preview-pages info -->", | |
| "<!-- voicevox preview-pages info -->", |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Merged
Hiroshiba
approved these changes
Nov 24, 2024
|
mainブランチのCDが落ちてそう？（把握されてる気がしますがとりあえずコメント） |
|
修正をこっちに入れ忘れてました… gitGraph
commit ID: "..."
branch pr/13
commit ID: "バグを埋め込む"
branch pr/14
commit ID: "新機能を作る"
commit ID: "バグに気がついて直す"
checkout main
merge pr/13
commit ID: "いまここ"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
アップロード後にコメントを更新するようにするようにします。
Copilotに要約させてみた
This pull request includes several changes to the workflow and script files to improve the build and deployment processes. The key changes involve renaming and restructuring scripts, updating the workflow configuration, and modularizing common functionality into a shared file.
Workflow and Script Updates:
scripts/collect.tstoscripts/collectArtifacts.tsand updated the script to use modular imports from a newscripts/common.tsfile. [1] [2] [3]scripts/updateComments.tsto handle updating comments with deployment information.package.jsonto reflect the new script names and added a script for updating comments.Workflow Configuration Changes:
.github/workflows/update_pages.ymlto separate artifact collection and build steps, and added a step to update comments after deployment. [1] [2]Codebase Simplification:
scripts/common.tsto centralize shared constants and functions used across multiple scripts.src/composables/useDownloadData.tsto use theDownloadDatatype from the newscripts/common.tsfile.関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）