Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [0.15] remove obsolete parts #896

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore: [0.15] remove obsolete parts #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Install cargo-edit
if: ${{ env.VERSION != 'DEBUG' }}
shell: bash
run: cargo binstall cargo-edit@^0.11 --no-confirm --log-level debug --locked # NOTE: release-0.15で追加
run: cargo binstall cargo-edit@^0.11 --no-confirm --log-level debug
- name: set cargo version
if: ${{ env.VERSION != 'DEBUG' }}
shell: bash
Expand Down
3 changes: 0 additions & 3 deletions crates/voicevox_core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ pub enum Error {
)]
InvalidModelIndex { model_index: usize },

#[error("{}", base_error_message(VOICEVOX_RESULT_UNSUPPORTED_MODEL_ERROR))]
UnsupportedModel,

#[error("{}", base_error_message(VOICEVOX_RESULT_INFERENCE_ERROR))]
InferenceFailed,

Expand Down
3 changes: 0 additions & 3 deletions crates/voicevox_core/src/publish.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,6 @@ pub const fn error_result_to_message(result_code: VoicevoxResultCode) -> &'stati
VOICEVOX_RESULT_UNINITIALIZED_STATUS_ERROR => "Statusが初期化されていません\0",
VOICEVOX_RESULT_INVALID_SPEAKER_ID_ERROR => "無効なspeaker_idです\0",
VOICEVOX_RESULT_INVALID_MODEL_INDEX_ERROR => "無効なmodel_indexです\0",
VOICEVOX_RESULT_UNSUPPORTED_MODEL_ERROR => "未対応なモデルです\0",
VOICEVOX_RESULT_INFERENCE_ERROR => "推論に失敗しました\0",
VOICEVOX_RESULT_EXTRACT_FULL_CONTEXT_LABEL_ERROR => {
"入力テキストからのフルコンテキストラベル抽出に失敗しました\0"
Expand Down Expand Up @@ -1164,8 +1163,6 @@ mod tests {
assert_eq!(result.unwrap().len(), vowel_phoneme_vector.len());
}

// TODO: sing系のテストを足す

#[rstest]
fn decode_works() {
let internal = VoicevoxCore::new_with_mutex();
Expand Down
2 changes: 0 additions & 2 deletions crates/voicevox_core/src/result_code.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ pub enum VoicevoxResultCode {
VOICEVOX_RESULT_INVALID_SPEAKER_ID_ERROR = 7,
/// 無効なmodel_indexが指定された
VOICEVOX_RESULT_INVALID_MODEL_INDEX_ERROR = 8,
/// 対応していないmodelが指定された
VOICEVOX_RESULT_UNSUPPORTED_MODEL_ERROR = 15,
/// 推論に失敗した
VOICEVOX_RESULT_INFERENCE_ERROR = 9,
/// コンテキストラベル出力に失敗した
Expand Down
1 change: 0 additions & 1 deletion crates/voicevox_core_c_api/src/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ pub(crate) fn into_result_code_with_error(result: CApiResult<()>) -> VoicevoxRes
Err(RustApi(UninitializedStatus)) => VOICEVOX_RESULT_UNINITIALIZED_STATUS_ERROR,
Err(RustApi(InvalidSpeakerId { .. })) => VOICEVOX_RESULT_INVALID_SPEAKER_ID_ERROR,
Err(RustApi(InvalidModelIndex { .. })) => VOICEVOX_RESULT_INVALID_MODEL_INDEX_ERROR,
Err(RustApi(UnsupportedModel { .. })) => VOICEVOX_RESULT_UNSUPPORTED_MODEL_ERROR,
Err(RustApi(InferenceFailed)) => VOICEVOX_RESULT_INFERENCE_ERROR,
Err(RustApi(ExtractFullContextLabel(_))) => {
VOICEVOX_RESULT_EXTRACT_FULL_CONTEXT_LABEL_ERROR
Expand Down
Loading