Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove!: requires-python>=3.10に引き上げる #915

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 2, 2025

内容

requires-python>=3.10に引き上げた上、 #873 の解決を確認する。

Python 3.9, 3.10の機能を使うことは別PRで行う。

関連 Issue

Resolves: #873

その他

Python 3.8での確認をしたときは以下のような感じ。10回実行しなくても多分ほぼほぼ10/10で引っ掛かる。
https://github.com/qryxip/voicevox_core/actions/runs/12584483928

@qryxip qryxip requested a review from Hiroshiba January 2, 2025 15:29
@Hiroshiba
Copy link
Member

Hiroshiba commented Jan 3, 2025

認識としてはpython3.10にしたら #873 問題が起きなくなった、ということで合っていますか?👀

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip qryxip merged commit 5eae9c5 into VOICEVOX:main Jan 3, 2025
30 checks passed
@qryxip qryxip deleted the remove-bump-requires-python-to-3-10 branch January 3, 2025 09:05
@qryxip
Copy link
Member Author

qryxip commented Jan 3, 2025

そうですね。Fatal Python errorだけだったら再現性の低さから確証を持つことがが難しかったのですが、StopIterationに着目することである程度持てるようになりました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python async APIのシャットダウン周りがなんかおかしい
2 participants