Add aarch64-pc-cygwin-target
#6
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhex
commented
Dec 9, 2024
Blackhex
commented
Dec 9, 2024
Blackhex
changed the title
aarch64-pc-cygwin-targetaarch64-pc-cygwin-target
Blackhex
force-pushed
the
woarm64-cygwin
branch
from
2705d88 to
c015cfe
Compare
Blackhex
changed the title
aarch64-pc-cygwin-targetaarch64-pc-cygwin-target
Blackhex
force-pushed
the
woarm64-cygwin
branch
from
c015cfe to
bb33c99
Compare
Blackhex
force-pushed
the
woarm64
branch
2 times, most recently
from
73c50a4 to
4bf4b4f
Compare
Blackhex
force-pushed
the
woarm64-cygwin
branch
from
bb33c99 to
fbc6005
Compare
vejbomar
reviewed
Jan 2, 2025
| #ifdef _WIN64 | ||
| #if defined(_WIN64) | ||
| #if defined(__aarch64__) | ||
| typedef long int ssize_t; |
There was a problem hiding this comment.
Why is this long int and not __int64?
From the context it seems to me that this should correcpond to pointer size and afaik long int is 32bits on Windows aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
aarch64-pc-cygwintarget support.Tested by: