XDP: Timer synchronization and microcontroller trace changes #8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: parthash0804 <ParthAshwin.Jain@amd.com>
Signed-off-by: parthash0804 <ParthAshwin.Jain@amd.com>
pgschuey
requested changes
Jan 7, 2025
There was a problem hiding this comment.
PR looks good. Why were new files created in the trace util subdirectory instead of adding the new functions to the existing aie_trace_config.* files? The idea of the util directory was to include functions common across implementations, so marking a file as common is redundant.
|
Except for concern raised by Paul for new files, the PR looks good. If we absolutely need the new files, please add copyright message. |
IshitaGhosh
requested changes
Jan 7, 2025
Signed-off-by: parthash0804 <ParthAshwin.Jain@amd.com>
|
@pgschuey I have made the changes as per your suggestions we had offline. |
jvillarre
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Timer were not in sync for ve2 device and microcontroller trace was not supported.
How problem was solved, alternative solutions (if any) and why they were rejected
Generated user event in cdo which will trigger the broadcast network and will be used to start the trace modules. Moved timer synchronization from cdo to XDP. @jyothees99 implemented the trace module start broadcast network.
Risks (if any) associated the changes in the commit
Aie_partition_info query from XRT which we are using is returning incorrect information, so until that is fixed trace won't be generated. We have informed @chvamshi-xilinx and @saifuddin-xilinx about it.
Micro controller trace has not been tested because the metric set changes needs to be submitted by @pgschuey . It will be submitted once this PR is merged.
What has been tested and how, request additional testing if necessary
Tested a multi layer design on QEMU+A72 flow.
Documentation impact (if any)
NA