Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBump] Merge with fixes of 76303791 (May 22) (51) #310

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

mgehre-amd
Copy link
Collaborator

No description provided.

cferry-AMD and others added 2 commits May 22, 2024 16:33
….extui

This commit adds conversion to EmitC for arith dialect casts between integer types (trunc, extsi, extui), excluding indexes for now.
@mgehre-amd mgehre-amd requested a review from cferry-AMD August 26, 2024 09:08
@cferry-AMD
Copy link
Collaborator

We're missing the upstream test

func.func @arith_extsi_i1_to_i32(%arg0: i1) {
  // expected-error @+1 {{failed to legalize operation 'arith.extsi'}}
  %idx = arith.extsi %arg0 : i1 to i32
  return
}

@mgehre-amd
Copy link
Collaborator Author

We're missing the upstream test

func.func @arith_extsi_i1_to_i32(%arg0: i1) {
  // expected-error @+1 {{failed to legalize operation 'arith.extsi'}}
  %idx = arith.extsi %arg0 : i1 to i32
  return
}

Good catch. I wanted to look at the difference between our branch and upstream later on to detect more of those issues; but now that you already found it, I'll push a fix.

@mgehre-amd mgehre-amd self-assigned this Aug 26, 2024
@mgehre-amd
Copy link
Collaborator Author

We're missing the upstream test

func.func @arith_extsi_i1_to_i32(%arg0: i1) {
  // expected-error @+1 {{failed to legalize operation 'arith.extsi'}}
  %idx = arith.extsi %arg0 : i1 to i32
  return
}

Good catch. I wanted to look at the difference between our branch and upstream later on to detect more of those issues; but now that you already found it, I'll push a fix.

Fixed, please re-review

Base automatically changed from bump_to_267de854 to feature/fused-ops September 4, 2024 05:02
@mgehre-amd mgehre-amd merged commit 4c3cc64 into feature/fused-ops Sep 4, 2024
3 checks passed
@mgehre-amd mgehre-amd deleted the bump_to_76303791 branch September 4, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants