Skip to content

Commit

Permalink
Remove 0-size dimension slice from pass set
Browse files Browse the repository at this point in the history
Upstream `SliceOutOfUpperBoundIndexStaticModule_basic` passes for TOSA. However, it should not, and our fork properly fails to lower, hence, the test is dropped from the pass set.

Currently produced slice operator:
```
Legalizing operation : 'tosa.slice'(0x55f54e681990) {
    %10 = "tosa.slice"(%0) <{size = array<i64: 6, 4, 0>, start = array<i64: 0, 0, 7>}> : (tensor<6x4x7xf32>) -> tensor<6x4x0xf32>

} -> SUCCESS : operation marked legal by the target
```

The output shape has dimensions of size zero, which is not allowed in TOSA.
  • Loading branch information
TinaAMD committed Nov 23, 2023
1 parent 89a4d36 commit 7e81c59
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion e2e_testing/xfail_sets.py
Original file line number Diff line number Diff line change
Expand Up @@ -1292,7 +1292,6 @@
"SliceStaticModule_basic",
"SliceSizeTwoStepDivisibleStaticModule_basic",
"SliceOutOfLowerBoundStartIndexStaticModule_basic",
"SliceOutOfUpperBoundIndexStaticModule_basic",
"ArangeStartStepIntModule_basic",
"ArangeDtypeFloatModule_basic",
"ArangeIntModule_basic",
Expand Down

0 comments on commit 7e81c59

Please sign in to comment.