Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBump] Merge with aa7e77ee (Sep 25) (58) #420

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

mgehre-amd
Copy link
Collaborator

No description provided.

giacs-epic and others added 6 commits September 23, 2024 12:09
…o torch dialect (llvm#3676)

- When the signal tensor is real, onnx allows its shape to be
`[batch][length]` as well as `[batch][length][1]`.
- Onnx also allows to specify `frame_length` together with `window` (not
empty), given that it matches the window size.
- Adding checks on signal and result shapes.
This documents which CMake options must be set to be able to use
`torch_mlir_e2e_test`, required e.g. for
`projects/pt1/tools/e2e_test.sh`.

Makes progress on llvm#3696.
Closes llvm#3719.
…tenIntOp (llvm#3730)

Fixes iree-org/iree#18562.

During canonicalization pass on `AtenUnflattenIntOp`, if the second dim
was statically equal to one, we would create an `AtenAddIntOp` to add
one to the dimension obtained from `op.getDim()`. This, when passed into
`Torch::unsqueezeTensor()`, would make it get interpreted as
non-constant, which would lead to MLIR failing an assertion when
`UnsqueezeOp` would later get lowered into `ExpandShapeOp`, as the
output of the `UnsqueezeOp` would consist of only dynamic dims.

This patch fixes this behavior, by extracting the integer value from the
dim if it was constant, and then emitting a `ConstantIntOp` from
(dim+1). This creates an output with static shape.
Instead of 
`Unhandled type in getScalarTypeForType`

You now get

Unhandled type in getScalarTypeForType: (type name)
Type properties:
  Is integer: yes
  Bit width: 
...


The root cause is llvm#3720, at
least for unsigned integer issues.
@mgehre-amd mgehre-amd requested a review from jorickert December 16, 2024 22:54
Base automatically changed from bump_to_3f79a298 to feature/backport_ea1_ops December 17, 2024 13:46
@mgehre-amd mgehre-amd merged commit 3a028cd into feature/backport_ea1_ops Dec 17, 2024
4 checks passed
@mgehre-amd mgehre-amd deleted the bump_to_aa7e77ee branch December 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants