test: update cypress tests to new budget format

Xiphe · Oct 20, 2020 · 25ffaa3 · 25ffaa3
1 parent 63e4819
commit 25ffaa3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/cypress/factories/settings.ts b/cypress/factories/settings.ts
@@ -21,7 +21,6 @@ export default function createSettings(
     fractionDigits: 2,
     startDate: 1562450400000,
     startBalance: 0,
-    numberLocale: 'de-DE',
     ...settings,
   };
 }
diff --git a/cypress/integration/budget.spec.ts b/cypress/integration/budget.spec.ts
@@ -7,6 +7,7 @@ import {
 } from '../factories';
 
 const COMMON_IGNORED_CHANNELS = [
+  'UPDATE_LOCALE_COUNTRY_CODE',
   'FILE_EDITED',
   'SAVE_CANCELED',
   'UPDATE_COLOR_PREFERENCES',

diff --git a/cypress/integration/new.spec.ts b/cypress/integration/new.spec.ts
@@ -12,6 +12,7 @@ describe('Create New Budget', () => {
     cy.open({
       waitUntilLoaded: false,
       ignoreChannels: [
+        'UPDATE_LOCALE_COUNTRY_CODE',
         'FILE_EDITED',
         'SAVE_CANCELED',
         'UPDATE_COLOR_PREFERENCES',
@@ -29,9 +30,6 @@ describe('Create New Budget', () => {
 
     cy.findByLabelText(/Name/i).type('My New Budget');
     cy.findByText(accounts[0].name).click();
-    cy.findByLabelText(/Number format/i)
-      .type('{selectall}')
-      .type('de-DE');
     cy.bb().then(({ electron: { ipcMain } }) => {
       ipcMain.handleOnce('MM_EXPORT_TRANSACTIONS', () => []);
     });
@@ -51,11 +49,10 @@ describe('Create New Budget', () => {
     cy.readBudget('/my_new.budget')
       .should('include', {
         name: 'My New Budget',
-        version: '0.0.2',
+        version: '0.0.3',
       })
       .and('deep.nested.include', {
         'settings.accounts': [accounts[0].uuid],
-        'settings.numberLocale': 'de-DE',
         'settings.startDate': 1562457600000,
         'settings.incomeCategories': [
           { id: categories[1].uuid, availableIn: 0 },
@@ -69,6 +66,7 @@ describe('Create New Budget', () => {
     cy.open({
       waitUntilLoaded: false,
       ignoreChannels: [
+        'UPDATE_LOCALE_COUNTRY_CODE',
         'FILE_EDITED',
         'SAVE_CANCELED',
         'UPDATE_COLOR_PREFERENCES',

diff --git a/src/__mocks__/electron.ts b/src/__mocks__/electron.ts
@@ -8,7 +8,7 @@ type Menu<T> = {
   getMenuItemById: (id: string) => { enabled: boolean };
 };
 type PartialRemote = {
-  app: Pick<Remote['app'], 'name' | 'getPath' | 'getLocale'>;
+  app: Pick<Remote['app'], 'name' | 'getPath' | 'getLocaleCountryCode'>;
   systemPreferences: Pick<
     Remote['systemPreferences'],
     'getAccentColor' | 'getUserDefault'
@@ -29,8 +29,8 @@ const remote: PartialRemote = {
     getPath(name: string) {
       return `/_appPath/${name}`;
     },
-    getLocale() {
-      return 'en-GB';
+    getLocaleCountryCode() {
+      return 'DE';
     },
   },
   systemPreferences: {

diff --git a/src/lib/createNumberFormatter.ts b/src/lib/createNumberFormatter.ts
@@ -66,9 +66,9 @@ export function useNumberFormatter(fractionDigits: number) {
     const handler = () => {
       setLocaleCC(remote.app.getLocaleCountryCode());
     };
-    ipcRenderer.addListener('UPDATE_LOCALE_COUNTRY_CODE', handler);
+    ipcRenderer.on('UPDATE_LOCALE_COUNTRY_CODE', handler);
     return () => {
-      ipcRenderer.removeListener('UPDATE_LOCALE_COUNTRY_CODE', handler);
+      ipcRenderer.off('UPDATE_LOCALE_COUNTRY_CODE', handler);
     };
   }, []);