test: do not wait until loaded in new budget test

Xiphe · May 17, 2020 · 9a0af16 · 9a0af16
1 parent f1535a4
commit 9a0af16
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/cypress/integration/createNewBudget.spec.ts b/cypress/integration/createNewBudget.spec.ts
@@ -10,6 +10,7 @@ describe('Create New Budget', () => {
     const categories = [category(), category(), category()];
 
     cy.open({
+      waitUntilLoaded: false,
       ignoreChannels: [
         'FILE_EDITED',
         'SAVE_CANCELED',

diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts
@@ -18,6 +18,7 @@ type BBexposed = BB & {
 };
 type OpenConfig = {
   setup?: (bb: BB) => void | Promise<void>;
+  waitUntilLoaded?: boolean;
   ignoreChannels: string[];
 };
 
@@ -72,13 +73,18 @@ Cypress.Commands.add('readBudget', (file: string) => {
 Cypress.Commands.add('cleanup', () => {
   cy._bb().then(({ _electron }) => _electron.cleanup());
 });
-Cypress.Commands.add('open', ({ setup, ignoreChannels }) => {
-  cy.visit('/');
-  cy._bb().then(({ _electron }) => {
-    _electron.ignoreChannels(ignoreChannels);
-  });
-  cy.bb().then(setup);
-  cy._bb().then(({ _startApp }) => _startApp());
-  cy.findByText(/BudgetBudget - Loading/i).should('be.visible');
-  cy.findByText(/BudgetBudget - Loading/i).should('not.be.visible');
-});
+Cypress.Commands.add(
+  'open',
+  ({ setup, ignoreChannels, waitUntilLoaded = true }) => {
+    cy.visit('/');
+    cy._bb().then(({ _electron }) => {
+      _electron.ignoreChannels(ignoreChannels);
+    });
+    cy.bb().then(setup);
+    cy._bb().then(({ _startApp }) => _startApp());
+    if (waitUntilLoaded) {
+      cy.findByText(/BudgetBudget - Loading/i).should('be.visible');
+      cy.findByText(/BudgetBudget - Loading/i).should('not.be.visible');
+    }
+  },
+);