Merge pull request #20 from YieldStudio/18-command-check-expo-tickets…

…-error-json_decode-argument-1-$json-must-be-of-type-string-array-given Prevent json_decode on responseItem details which is array
YieldStudio · Nov 14, 2023 · 9102290 · 9102290
2 parents 407391d + 0d5fc1d
commit 9102290
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Dto/ExpoMessage.php b/src/Dto/ExpoMessage.php
@@ -14,7 +14,7 @@
  * @author David Tang<david@yieldstudio.fr>
  * @author James Hemery<james@yieldstudio.fr>
  */
-final class ExpoMessage implements Jsonable, Arrayable
+final class ExpoMessage implements Arrayable, Jsonable
 {
     public array $to;
 

diff --git a/src/ExpoNotificationsService.php b/src/ExpoNotificationsService.php
@@ -121,7 +121,7 @@ public function receipts(Collection|array $tokenIds): Collection
             if ($responseItem['status'] === ExpoResponseStatus::ERROR->value) {
                 $data
                     ->message($responseItem['message'])
-                    ->details(json_decode($responseItem['details'], true));
+                    ->details($responseItem['details']);
             }
 
             return $data;

diff --git a/src/Jobs/CheckTickets.php b/src/Jobs/CheckTickets.php
@@ -17,8 +17,8 @@
 class CheckTickets
 {
     use Dispatchable;
-    use SerializesModels;
     use Queueable;
+    use SerializesModels;
 
     public function handle(
         ExpoNotificationsService $expoNotificationsService,

diff --git a/src/Jobs/SendPendingNotifications.php b/src/Jobs/SendPendingNotifications.php
@@ -14,8 +14,8 @@
 class SendPendingNotifications
 {
     use Dispatchable;
-    use SerializesModels;
     use Queueable;
+    use SerializesModels;
 
     public function handle(
         ExpoNotificationsService $expoNotificationsService,