Skip to content

Commit

Permalink
drivers: stepper: shell: Use shell_device_filter
Browse files Browse the repository at this point in the history
Use the shell_device_filter utils method and leverage the new api classing
to only suggest stepper devices via tab-complete within the shell.

Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
  • Loading branch information
faxe1008 authored and kartben committed Dec 27, 2024
1 parent 02fa47f commit fc25679
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/stepper/stepper_shell.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ static void print_callback(const struct device *dev, const enum stepper_event ev
}
}

static bool stepper_device_check(const struct device *dev)
{
return DEVICE_API_IS(stepper, dev) && device_is_ready(dev);
}

static const struct stepper_direction_map stepper_direction_map[] = {
STEPPER_DIRECTION_MAP_ENTRY("positive", STEPPER_DIRECTION_POSITIVE),
STEPPER_DIRECTION_MAP_ENTRY("negative", STEPPER_DIRECTION_NEGATIVE),
Expand Down Expand Up @@ -114,7 +119,7 @@ SHELL_DYNAMIC_CMD_CREATE(dsub_stepper_microstep, cmd_stepper_microstep);

static void cmd_pos_stepper_motor_name(size_t idx, struct shell_static_entry *entry)
{
const struct device *dev = shell_device_lookup(idx, NULL);
const struct device *dev = shell_device_filter(idx, stepper_device_check);

entry->syntax = (dev != NULL) ? dev->name : NULL;
entry->handler = NULL;
Expand All @@ -126,7 +131,7 @@ SHELL_DYNAMIC_CMD_CREATE(dsub_pos_stepper_motor_name, cmd_pos_stepper_motor_name

static void cmd_pos_stepper_motor_name_dir(size_t idx, struct shell_static_entry *entry)
{
const struct device *dev = shell_device_lookup(idx, NULL);
const struct device *dev = shell_device_filter(idx, stepper_device_check);

if (dev != NULL) {
entry->syntax = dev->name;
Expand All @@ -142,7 +147,7 @@ SHELL_DYNAMIC_CMD_CREATE(dsub_pos_stepper_motor_name_dir, cmd_pos_stepper_motor_

static void cmd_pos_stepper_motor_name_microstep(size_t idx, struct shell_static_entry *entry)
{
const struct device *dev = shell_device_lookup(idx, NULL);
const struct device *dev = shell_device_filter(idx, stepper_device_check);

if (dev != NULL) {
entry->syntax = dev->name;
Expand Down

0 comments on commit fc25679

Please sign in to comment.