Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise MBRGenerationConfig #4

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

jvamvas
Copy link
Member

@jvamvas jvamvas commented Dec 27, 2023

  • Remove GenerationConfig as parent class to avoid confusion with the generation_config, references_config objects passed to generate(), which also inherit from GenerationConfig
  • Rename to MBRConfig

@jvamvas jvamvas merged commit 189e396 into ZurichNLP:main Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant