Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new dlc units to the dataset #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shyam-s00
Copy link

I've added new dlc units to the dataset.

@aalises
Copy link
Owner

aalises commented Jul 6, 2021

Hey @shyam-s00 , seems like it broke the tests. Could you check it? thanks!

@shyam-s00
Copy link
Author

shyam-s00 commented Jul 6, 2021

@aalises Does the test run against the data from DB for asserting?

@kprkr
Copy link

kprkr commented Sep 9, 2021

Any luck with this? Hoping for a full API (with new DLC civs)

@gvrettos
Copy link
Contributor

gvrettos commented Feb 3, 2024

@aalises Does the test run against the data from DB for asserting?

@shyam-s00
Indeed, that is the case. If you check this test here you will see that the API calls the database.
So, any changes to the csv files would mean that also changes in the database file are required.
Finally, keep in mind that Python 3.6.x is suggested. I had a try with 3.9.x but the tests failed with the lazy='dynamic' options used in relationships between tables. In 3.6.x this is just a warning, so the tests pass.

P.S. I know I am late to the party 😄, but as a previous consumer now I take the chance to dive into this API. Many 👍 to the creator @aalises!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants