Skip to content

Commit

Permalink
switch shellcheck action
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronhurt committed Aug 23, 2024
1 parent ec286aa commit f9429fc
Show file tree
Hide file tree
Showing 3 changed files with 464 additions and 460 deletions.
20 changes: 12 additions & 8 deletions .github/workflows/status-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: status checks
on:
push:
branches:
- master
- main
- master
pull_request:

permissions:
Expand All @@ -12,7 +12,7 @@ permissions:

jobs:
shfmt:
name: run shfmt
name: runner / shfmt
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -24,13 +24,17 @@ jobs:
shfmt_flags: '-ln bash -ci -sr -i 2'

shellcheck:
name: shellcheck
name: runner / shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: run ShellCheck
uses: ludeeus/action-shellcheck@master
- name: shellcheck
uses: reviewdog/action-shellcheck@v1
with:
ignore_paths: ./config.sample.sh
env:
SHELLCHECK_OPTS: --check-sourced --shell=bash
level: info
reporter: github-check
filter_mode: nofilter
fail_on_error: true
exclude: |
"./.git/*"
"./config.sample.sh"
4 changes: 2 additions & 2 deletions get-last-status.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ SCRIPTPATH=$(dirname "${SCRIPT}")

# Check for existing logs
if ! [ -e ${SCRIPTPATH}/logs ]; then

Check warning on line 8 in get-last-status.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./get-last-status.sh:8:11: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
echo "Log directory does not exist, can't check status."
exit 0
echo "Log directory does not exist, can't check status."
exit 0
fi

# Set log directory
Expand Down
Loading

0 comments on commit f9429fc

Please sign in to comment.