Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better nominate #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

better nominate #31

wants to merge 5 commits into from

Conversation

exd02
Copy link
Contributor

@exd02 exd02 commented Feb 27, 2024

  • Find the map with string containing the given name
  • Added translation (with ChatGPT) for the case of multiple maps with the same given name

*Example: Before, the !nominate swag command didn't return any maps
Captura de tela 2024-02-27 002124

@exd02 exd02 changed the title Find map containing the given name better nominate and right output dir Feb 27, 2024
@abnerfs
Copy link
Owner

abnerfs commented Feb 28, 2024

Thanks for the contribution, about changing the folder structure I see no value, I have a github action that generates the build automatically when I upload a new tag, so build it to bin is working fine, I also don't like having the entire folder structure from addons in the zip, just the RockTheVote folder is enough.
About the nomination search it seems interesting, I will take a closer look in your implementation soon before we merge it, note that adding a new phrase to the translation means you need to add it to all languages the plugin supports not only to en and pt-br https://github.com/abnerfs/cs2-rockthevote?tab=readme-ov-file#translations so we also need to get it translated before merging

@exd02 exd02 force-pushed the main branch 2 times, most recently from 492c2ac to 3512ae4 Compare February 28, 2024 16:33
@exd02 exd02 changed the title better nominate and right output dir better nominate Feb 28, 2024
@exd02
Copy link
Contributor Author

exd02 commented Feb 28, 2024

  • Removed folder structure thing
  • Added translation to all languages (using ChatGPT)

Tested again:
image

@exd02
Copy link
Contributor Author

exd02 commented Feb 28, 2024

It's causing error when nominating a map with a similar name (I have mg_minecraft and mg_minecraft_aphixed):
image

@exd02
Copy link
Contributor Author

exd02 commented Feb 28, 2024

fixed

@Oylneechan
Copy link

Suggestion: Make a menu for in case there are more than 2 maps that contain the same name. If this is not in your plan now, maybe we could add it later.

Oz-Lin added a commit to Oz-Lin/cs2-rockthevote that referenced this pull request Jun 2, 2024
@Oz-Lin
Copy link

Oz-Lin commented Jun 2, 2024

Suggestion: Make a menu for in case there are more than 2 maps that contain the same name. If this is not in your plan now, maybe we could add it later.

Will work on this as well if I have time

@Oz-Lin
Copy link

Oz-Lin commented Sep 5, 2024

Oz-Lin@1c19a3b
Listed in chat when multiple maps that contain the same name for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants