Fix bug at following package license references #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #3969 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
approved these changes
Nov 18, 2024
pombredanne
reviewed
Nov 18, 2024
| @@ -140,6 +140,9 @@ def add_referenced_license_matches_for_package(resource, codebase): | |||
| ): | |||
| continue | |||
|
|
|||
| if not (referenced_resource and referenced_resource.license_detections): | |||
There was a problem hiding this comment.
Actually, referenced_resource is referenced below outside of this loop and may not exists at all.
pombredanne
requested changes
Nov 18, 2024
pombredanne
reviewed
Nov 18, 2024
| @@ -314,15 +317,15 @@ def add_referenced_filenames_license_matches_for_detections(resource, codebase): | |||
| referenced_license_expression=referenced_license_expression, | |||
| license_detection=license_detection, | |||
| ): | |||
| if TRACE_REFERENCE: | |||
| if TRACE_REFERENCE and referenced_resource: | |||
There was a problem hiding this comment.
referenced_resource is declared in another scope, which may be a problem. You may want to track referenced_resources_with_detections as a list of Resource rather than referenced_detections so you can:
- debug trace as needed
- account for when you have more than one file referenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3969
Tasks
Run tests locally to check for errors.