Added support for parsing private classifier #3989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VarshaUN
force-pushed
the
support-python-private-package
branch
from
ff1685e to
f3511cf
Compare
AyanSinhaMahapatra
requested changes
Nov 29, 2024
There was a problem hiding this comment.
@VarshaUN Thanks++
Please always run subset of tests where you have made changes locally and look for test failures. And then also look for test failures in the CI and fix any issues present there too.
tests/packagedcode/test_pypi.py
Outdated
| @@ -339,6 +339,12 @@ def test_parse_pyproject_toml_standard_lc0(self): | |||
| expected_loc = self.get_test_loc('pypi/pyproject-toml/standard/lc0-pyproject.toml-expected.json') | |||
| self.check_packages_data(package, expected_loc, regen=REGEN_TEST_FIXTURES) | |||
|
|
|||
| def test_parse_pyproject_toml_private_package(self): | |||
| test_file = self.get_test_loc('pypi/pyproject-toml/private/private_package/pyproject.toml') | |||
There was a problem hiding this comment.
You've added a test but no test file, so this is failing with an OSError, no file found. Please add the corresponding test and expected files too. See https://scancode-toolkit.readthedocs.io/en/stable/contribute/contrib_dev.html#running-tests on how to regen files selectively.
VarshaUN
force-pushed
the
support-python-private-package
branch
from
36af28a to
0a92f7f
Compare
…N <varshaun58@gmail.com> Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
VarshaUN
force-pushed
the
support-python-private-package
branch
from
52ef305 to
25f5adb
Compare
|
@AyanSinhaMahapatra I have added every required files now. Please review it |
|
@AyanSinhaMahapatra I have added the changes you told me. Please review it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3968
Tasks
Run tests locally to check for errors.
Signed-off-by: Varsha U N varshaun58@gmail.com