Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set runs.using to node22 #502

Closed
wants to merge 1 commit into from
Closed

Conversation

ghoullier
Copy link

@ghoullier ghoullier commented Dec 17, 2024

Hello,

Important

This PR introduce a breaking change given it change the target node version from 20 to 22

Purpose

NodeJS 22 is the LTS from October 2024.

To support new features like require(esm) or ES2024+ it would be nice if this action runs on node22

NodeJS Releases

Capture d’écran 2024-12-17 à 16 09 17

Changes

  • change runs.using to node22
  • change engines.node to ">=22.0.0 <23.0.0"
  • bump @types/node to "^22.10.2"
  • update .github/actions/install-dependencies/action.yml to support node22

@ghoullier ghoullier requested a review from a team as a code owner December 17, 2024 15:11
@ghoullier ghoullier force-pushed the patch-1 branch 2 times, most recently from af5442a to 4554e0a Compare December 17, 2024 15:17
NodeJS 22 is the LTS from October 2024
@ghoullier ghoullier changed the title feat!: set runs.using to node22 feat!: set runs.using to node22 Dec 17, 2024
Copy link

@Setland34 Setland34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@joshmgross
Copy link
Member

joshmgross commented Jan 9, 2025

Node 20 is the only actively supported version of Node for Javascript actions - https://docs.github.com/en/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

We went from Node 12 to 16 to 20, so I suspect the next version of Node we'll support will be Node 24 once it's LTS. Adding a new Node versions increases the size of the Actions runner binary and deprecating old versions is a long, drawn-out process so we won't support every LTS version of Node.

If you'd like for Node 22 to be supported, feel free to open an issue in https://github.com/actions/runner

@joshmgross joshmgross closed this Jan 9, 2025
@lourd
Copy link

lourd commented Jan 10, 2025

Looks like there's an open issue for v22 support on actions/runner here actions/runner#3600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants