Update/Add Ninja #741

compnerd · 2020-04-19T19:13:34Z

Tool information

Tool name: Ninja
Add or update? Add
Desired version: latest
Approximate size:
If this is an add request:
- Brief description of tool: ninja is a build tool focused on speed
- URL for tool's homepage: https://github.com/ninja-build/ninja

Area for Triage:
Packages

Question, Bug, or Feature?:
Feature

Virtual environments affected

Can this tool be installed during the build?
Yes, the install is bound by download time (usually ~1m)

Are you willing to submit a PR?
Yes

The text was updated successfully, but these errors were encountered:

compnerd · 2020-04-19T19:14:43Z

The ninja tool is already included in the Windows hosts via Visual Studio. It would be nice to include it on the macOS and Ubuntu VMs. For Ubuntu, apt-get install -y ninja-build is sufficient.

miketimofeev · 2020-04-19T19:21:48Z

Hi @compnerd! As I know ninja is installed along with vcpkg, here is the vcpkg installation log:

    azure-arm: Downloading ninja...
==> azure-arm:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
==> azure-arm:                                  Dload  Upload   Total   Spent    Left  Speed
==> azure-arm: 100   624  100   624    0     0   2034      0 --:--:-- --:--:-- --:--:--  2039
==> azure-arm: 100 99857  100 99857    0     0  99025      0  0:00:01  0:00:01 --:--:--  322k
    azure-arm: Downloading ninja... done.
    azure-arm: Extracting ninja...
    azure-arm: Extracting ninja... done.

I wonder if it could be used for your purposes?

compnerd · 2020-04-19T19:38:46Z

@miketimofeev interesting, ninja is definitely not found on the Linux builders (on Azure). I thought that the Azure and GitHub actions were merged into a single repository.

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
-- Configuring incomplete, errors occurred!
See also "/home/vsts/work/1/b/.../CMakeFiles/CMakeOutput.log".

Add ninja-build to the Linux images. It is already present on the Windows builders and is very often used with CMake. Issue: actions#741

miketimofeev · 2020-04-19T19:43:14Z

@compnerd Unfortunately, I'm not so familiar with CMake builds, but is it possible to use vcpkg for them?
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_configure_cmake.md

compnerd · 2020-04-19T19:46:04Z

@miketimofeev no, it is not possible to use vcpkg for building for my purposes. I need to be able to use ninja directly through CMake as that is the only way that you can build Swift packages with CMake. The projects only support CMake, and supporting vcpkg is not viable as adding yet another build system to projects is not likely to be accepted.

compnerd · 2020-04-19T19:47:27Z

@miketimofeev actually, thinking more about this - isn't this actually better? Adding ninja to the base image allows CMake to use it and vcpkg could use the host provided ninja builder as well.

miketimofeev · 2020-04-19T19:48:48Z

Oh, I see. Can that ninja from vcpkg be used directly from /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja?
We try to avoid tools duplicating, that's why I'm trying to find any possible ways.

compnerd · 2020-04-19T19:49:52Z

Hardcoding random paths doesn't work very well for the azure pipelines if you are using different builders. Can you not use ninja from /usr/bin/ninja instead of /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja?

Alternatively, you could symlink the path from /usr/bin/ninja.

miketimofeev · 2020-04-19T19:50:58Z

If this path works /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja then we can simply add a symlink

compnerd · 2020-04-19T19:51:47Z

Where the tool resides is not a big deal, if ninja can be added to the path for all the builders, that is perfectly acceptable (though beyond my ability to help with).

miketimofeev · 2020-04-19T19:56:19Z

Can you confirm that
sudo ln -s /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja /usr/local/bin/ninja solves your task?
If yes – we'll consider making the symlink during the vcpkg installation

compnerd · 2020-04-19T20:00:47Z

@miketimofeev nope, that still fails. I can verify that sudo apt-get install ninja-build does fix it though.

compnerd · 2020-04-19T20:04:56Z

@miketimofeev also can verify that sudo ln -s /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja /usr/bin/ninja fails. Its not a PATH issue AFAICT.

Darleev · 2020-04-20T06:24:18Z

Hi @compnerd . We had very similar request for ninja tool. Unfortunately, we can't add it at the moment. I would like to suggest you to install ninja tool in runtime using the following steps:

# macOS
brew install ninja

# Ubuntu
sudo apt-get install ninja-build

So, currently, it's easy to install ninja in runtime on demand, since installation takes about 10 seconds and there are no issues with it.
If additional assistance or information is required, please do not hesitate to contact us.

abique · 2021-12-28T01:44:12Z

Hi @compnerd . We had very similar request for ninja tool. Unfortunately, we can't add it at the moment. I would like to suggest you to install ninja tool in runtime using the following steps:
# macOS
brew install ninja

# Ubuntu
sudo apt-get install ninja-build
So, currently, it's easy to install ninja in runtime on demand, since installation takes about 10 seconds and there are no issues with it. If additional assistance or information is required, please do not hesitate to contact us.

it is on windows that it is difficult to install ninja

al-cheb · 2021-12-28T06:56:15Z

it is on windows that it is difficult to install ninja

@abique , You can use choco to install ninja tool on Windows.

- run: |
        choco install ninja
        ninja.exe --version

E.g.:

It is required to install ninja manually due to it not being included in the virtual env provided by Github Actions runner. See actions/runner-images#741 Fixes: 216535050 Test: Github CI Change-Id: I1a741b1765822f0004adc3985b7babc8022046a5

It is required to install ninja manually due to it not being included in the virtual env provided by Github Actions runner. See actions/runner-images#741 In order for Ninja to be visible to CMake during NDK builds, it must be installed in the same subdirectory, so for now it is symlinked on Linux builds. See b/206099937 Fixes: 216535050 Test: Github CI Change-Id: I1a741b1765822f0004adc3985b7babc8022046a5

It is required to install ninja manually due to it not being included in the virtual env provided by Github Actions runner. See actions/runner-images#741 In order for Ninja to be visible to CMake during NDK builds, it must be installed in the same subdirectory, so for now it is symlinked on Linux builds. See b/206099937 This doesn't fully fix work-inspection due to missing the dexter/slicer import. Bug: 216535050 Test: Github CI Change-Id: I1a741b1765822f0004adc3985b7babc8022046a5 This is an imported pull request from #315. Resolves #315 Github-Pr-Head-Sha: 26c4156 GitOrigin-RevId: 63fff83 Change-Id: Id4b017d8748ce797beef76e5068211f6c31a492c

jpr42 · 2023-03-02T00:44:04Z

FWIW to CMake/Ninja users get-cmake has been amazing at work for grabbing the exact version of CMake/Ninja you want. It also implements GitHub caching 👍🏽 so you don't have to worry about sporadic network failures.

marc-hb · 2023-09-22T17:38:40Z

The ninja tool is already included in the Windows hosts via Visual Studio.

it is on windows that it is difficult to install ninja

I'm confused: is it available by default on Windows Server or not?

ninja just started ~~randomly~~ disappearing on Windows:

[BUG] [Windows CI] CMake was unable to find a build program corresponding to "Ninja" thesofproject/sof#8250

marc-hb · 2023-09-22T18:06:45Z

Looks like ninja was dropped from Windows image 20230918.1.

Either dropped or it's not in the PATH anymore.

jhasse · 2023-10-06T14:57:04Z

You can get it back on the path by adding https://github.com/marketplace/actions/enable-developer-command-prompt before calling CMake.

marc-hb · 2023-10-06T19:46:15Z

This enable-developer-command-prompt action looks great but unfortunately we use shell: msys2 {0} so I'm not optimistic enough to try it :-(

marc-hb · 2023-10-25T21:58:47Z

Gosh this really annoying:

20230910.1 ninja found
20230918.1 not found
20231016.1.0 ninja found
20231023.1.0 not found

To confuse users even more, the same run gets a mix of versions with some builds passing and others not. Who's having fun with this back and forth?

You can use choco to install ninja tool on Windows.

BTW this worked for us, thanks! Now we just need to use it on all our branches.

marc-hb · 2024-01-29T18:49:34Z

We had very similar request #514 for ninja tool. Unfortunately, we can't add it at the moment.

I just pleaded for #514 to be re-opened and reconsidered:

Add Ninja build system to Mac, Linux and Windows #514 (comment)

dofuuz · 2024-12-19T01:11:04Z

For now, using seanmiddleditch/gha-setup-ninja is fast and easy cross-platform way to use ninja.

    - uses: seanmiddleditch/gha-setup-ninja@v5

It takes ~1sec to setup ninja.

marc-hb · 2024-12-19T18:31:53Z

This looks great but security-conscious projects should not have to all perform duplicate audits of some 3rd party action for a build tool as fundamental as ninja.

marc-hb · 2024-12-22T18:47:45Z

thanks for your suggestion but considering that it' easy to add Ninja to workflows on demand,...

I just asked runtime installation to be officially documented, please upvote:

No official way to install ninja is documented #11235

Ever growing list of duplicates gathered at:

Add Ninja build system to Mac, Linux and Windows #514 (comment)

github-actions bot added the needs triage label Apr 19, 2020

compnerd added a commit to compnerd/virtual-environments that referenced this issue Apr 19, 2020

add ninja build to Linux images

18fcdf7

Add ninja-build to the Linux images. It is already present on the Windows builders and is very often used with CMake. Issue: actions#741

compnerd mentioned this issue Apr 19, 2020

add ninja build to Linux images #742

Closed

4 tasks

miketimofeev added Area: C/C++ enhancement New feature or request needs eyes OS: macOS OS: Ubuntu and removed needs triage labels Apr 19, 2020

Darleev closed this as completed Apr 20, 2020

dibir-magomedsaygitov mentioned this issue Sep 1, 2020

Update/Add Ninja #1531

Closed

1 task

targos mentioned this issue Feb 24, 2021

build: use Ninja in action workflows nodejs/node#37499

Closed

EwoutH mentioned this issue Apr 8, 2021

Create CI workflow with GitHub Actions google/lyra#5

Merged

PiotrSikora mentioned this issue May 13, 2021

build: enable WAMR and WAVM runtimes. proxy-wasm/proxy-wasm-cpp-host#162

Merged

dlam mentioned this issue Jan 27, 2022

Use exact version of NDK needed by presubmit in Github Actions androidx/androidx#315

Closed

marc-hb mentioned this issue Oct 20, 2023

[BUG] [Windows CI] CMake was unable to find a build program corresponding to "Ninja" thesofproject/sof#8250

Closed

marc-hb mentioned this issue Jan 29, 2024

Add Ninja build system to Mac, Linux and Windows #514

Closed

5 tasks

marc-hb mentioned this issue Dec 22, 2024

No official way to install ninja is documented #11235

Open

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update/Add Ninja #741

Update/Add Ninja #741

compnerd commented Apr 19, 2020 •

edited

Loading

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020 •

edited

Loading

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020 •

edited

Loading

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

compnerd commented Apr 19, 2020

Darleev commented Apr 20, 2020

abique commented Dec 28, 2021

al-cheb commented Dec 28, 2021 •

edited

Loading

jpr42 commented Mar 2, 2023

marc-hb commented Sep 22, 2023 •

edited

Loading

marc-hb commented Sep 22, 2023

jhasse commented Oct 6, 2023

marc-hb commented Oct 6, 2023

marc-hb commented Oct 25, 2023

marc-hb commented Jan 29, 2024 •

edited

Loading

dofuuz commented Dec 19, 2024 •

edited

Loading

marc-hb commented Dec 19, 2024

marc-hb commented Dec 22, 2024

Update/Add Ninja #741

Update/Add Ninja #741

Comments

compnerd commented Apr 19, 2020 • edited Loading

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020 • edited Loading

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020 • edited Loading

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

miketimofeev commented Apr 19, 2020

compnerd commented Apr 19, 2020

compnerd commented Apr 19, 2020

Darleev commented Apr 20, 2020

abique commented Dec 28, 2021

al-cheb commented Dec 28, 2021 • edited Loading

jpr42 commented Mar 2, 2023

marc-hb commented Sep 22, 2023 • edited Loading

marc-hb commented Sep 22, 2023

jhasse commented Oct 6, 2023

marc-hb commented Oct 6, 2023

marc-hb commented Oct 25, 2023

marc-hb commented Jan 29, 2024 • edited Loading

dofuuz commented Dec 19, 2024 • edited Loading

marc-hb commented Dec 19, 2024

marc-hb commented Dec 22, 2024

compnerd commented Apr 19, 2020 •

edited

Loading

compnerd commented Apr 19, 2020 •

edited

Loading

compnerd commented Apr 19, 2020 •

edited

Loading

al-cheb commented Dec 28, 2021 •

edited

Loading

marc-hb commented Sep 22, 2023 •

edited

Loading

marc-hb commented Jan 29, 2024 •

edited

Loading

dofuuz commented Dec 19, 2024 •

edited

Loading