-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CI workflow with GitHub Actions #5
Conversation
- Builds the encoder and decoder for Android - Builds the Android APK and uploads it to GitHub as build artifact and on releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We were meaning to get around to this, so this is very useful. I have some questions and comments.
- Disables the Android APK upload to GitHub and the deploy function (for now) - Pin the setup Ninja action
Thanks for your review! I think I implemented or answered all your suggestions and questions, please resolve the conversation if that's done satisfactory. As of the Linux job, I was indeed looking into installing that specific Clang version. To confirm: the latest stable release (11.1.0) won't cut it and llvm/llvm-project@96ef4f3 is needed specifically? |
Oh, wow, thanks for looking into that. |
I think this PR is ready, please tell me if you would like any cleanup done. I can squash them to one commit (losing history however), you can also squash them when merging. Edit: Also, don't forget to enable GitHub actions here: https://github.com/google/lyra/actions |
Looks good, thanks for the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes!
Create CI workflow with GitHub Actions which:
GitHub Actions needs to be enabled here: https://github.com/google/lyra/actions. In the mean time an example run can be found here.
Update: Removed the Linux build for now and cleaned up commits. A Linux build will be added in another PR since the specific version requirement makes it a little more complex.