Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CI workflow with GitHub Actions #5

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Apr 7, 2021

Create CI workflow with GitHub Actions which:

  • Builds the encoder and decoder for Android
  • Builds the Android APK and uploads it to GitHub as build artifact and on releases

GitHub Actions needs to be enabled here: https://github.com/google/lyra/actions. In the mean time an example run can be found here.

Update: Removed the Linux build for now and cleaned up commits. A Linux build will be added in another PR since the specific version requirement makes it a little more complex.

 - Builds the encoder and decoder for Android
 - Builds the Android APK and uploads it to GitHub as build artifact and on releases
Copy link
Collaborator

@mchinen mchinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We were meaning to get around to this, so this is very useful. I have some questions and comments.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
- Disables the Android APK upload to GitHub and the deploy function (for now)
- Pin the setup Ninja action
@EwoutH
Copy link
Contributor Author

EwoutH commented Apr 8, 2021

Thanks for your review! I think I implemented or answered all your suggestions and questions, please resolve the conversation if that's done satisfactory.

As of the Linux job, I was indeed looking into installing that specific Clang version. To confirm: the latest stable release (11.1.0) won't cut it and llvm/llvm-project@96ef4f3 is needed specifically?

@mchinen
Copy link
Collaborator

mchinen commented Apr 8, 2021

As of the Linux job, I was indeed looking into installing that specific Clang version. To confirm: the latest stable release (11.1.0) won't cut it and llvm/llvm-project@96ef4f3 is needed specifically?

Oh, wow, thanks for looking into that.
Yes, using that specific SHA would be ideal.

@EwoutH EwoutH requested a review from mchinen April 8, 2021 19:26
@EwoutH
Copy link
Contributor Author

EwoutH commented Apr 8, 2021

I think this PR is ready, please tell me if you would like any cleanup done. I can squash them to one commit (losing history however), you can also squash them when merging.

Edit: Also, don't forget to enable GitHub actions here: https://github.com/google/lyra/actions

@mchinen
Copy link
Collaborator

mchinen commented Apr 8, 2021

Looks good, thanks for the changes!

Copy link
Collaborator

@mchinen mchinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes!

@mchinen mchinen merged commit 79777fc into google:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants