Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to force the architecture #298

Closed
wants to merge 9 commits into from

Conversation

kevingosse
Copy link

@kevingosse kevingosse commented Jun 22, 2022

Description:
Add an optional architecture parameter to set the target architecture (x86, x64, arm64, ...).

Related issue:
#72

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@kevingosse kevingosse requested a review from a team June 22, 2022 16:59
@kevingosse
Copy link
Author

Any idea why the checks are failing on ubuntu/mac-OS? It looks like it produce a different dist.js, but I did run npm build and include the result to the PR.

@vsafonkin
Copy link

Any idea why the checks are failing on ubuntu/mac-OS? It looks like it produce a different dist.js, but I did run npm build and include the result to the PR.

@kevingosse could you try to remove index.js from dist directory and rebuild it again via npm run build?

@kevingosse
Copy link
Author

@vsafonkin I tried but it produces an identical file:

C:\git\setup-dotnet>del dist\index.js

C:\git\setup-dotnet>npm run build
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

> setup-dotnet@1.0.0 build
> tsc && ncc build

ncc: Version 0.33.4
ncc: Compiling file index.js into CJS
1109kB  dist\index.js
1109kB  [1020ms] - ncc 0.33.4

C:\git\setup-dotnet>git status
On branch kevin/architecture
Your branch is up to date with 'origin/kevin/architecture'.

nothing to commit, working tree clean

@IvanZosimov
Copy link
Contributor

Hi, @kevingosse 👋 Sorry for the delay, could I ask you to update your PR? There is a merge conflict because of the new released major version of the action.

@kevingosse kevingosse closed this Oct 21, 2022
@kevingosse
Copy link
Author

kevingosse commented Oct 21, 2022

Creating a new branch and redoing the change because there are just too many conflicts: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants