-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support global.json rollForward latest variants #481
base: main
Are you sure you want to change the base?
feat: support global.json rollForward latest variants #481
Conversation
the only way this is valid is if rollForward is `latestMajor`, which is the only value that the global.json spec says doesn't require a version to be specified
One concern I have is that the README states that using the partial version numbers will include prereleases (by default?).. which makes me think it should also support the
|
Co-authored-by: js6pak <me@6pak.dev>
Also addressed #397 (comment) |
Keep in mind because of the awful way github actions are distributed you have to run 3089bb1 is pointless because the Also the CI is failing which you can't see because the workflow is only enabled for pull requests and no one approved it for this one yet. In my opinion you should just disable the branch filtering here, it won't hurt to always run the check. I've pushed out actually working code here: https://github.com/js6pak/setup-dotnet/commits/feat/support-rollForward/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions.
This would be useful to us too at Speckle! |
Description:
This PR adds support for all of the
latest*
variants of rollForward option in theglobal.json
filelatestMajor
latestMinor
latestFeature
latestPatch
Related issue:
#448
Check list:
I'm not sure if it makes sense to add the same kind of test for
latestMajor
- it would break every time there's a new major release. If it weren't limited to regular expression checks, the test could provide an EOL sdk version such as3.1.426
, and the test could make sure that the resolved major version is greater than 3, but I'm not sure how to go about that.