-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement parsing for expected_match field #820
Closed
mertcanaltin
wants to merge
138
commits into
ada-url:main
from
mertcanaltin:mert/expected-match-parser
Closed
feat: implement parsing for expected_match field #820
mertcanaltin
wants to merge
138
commits into
ada-url:main
from
mertcanaltin:mert/expected-match-parser
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertcanaltin
changed the title
Mert/expected match parser
feat: implement parsing for expected_match field
Jan 2, 2025
I accidentally opened maine and I'm turning it off ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added parsing logic for expected_match to handle strings, null values, and objects safely
I’ve opened a PR on top of Yagiz’s (@anonrig) PR. Only the last commit is mine. I’d greatly appreciate it if you could take a look @lemire