-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Apple DART's RLE, corrects comments and copyright messages. #183
base: master
Are you sure you want to change the base?
Conversation
|
||
int copied = 0; | ||
|
||
fillBuffer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway you can do this without the goto
and label? Just bad C# style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mayyyyyyybe, I need to test.
And while most C# people tend to ignore gotos, they're used extensively in .NET frameworks and the IL optimizes them easy.
But if you prefer no goto I'll try to remove it, don't worry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a big deal. I may refactor later if you don't want to :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry I'll do it myself this week and with some luck I add compression.
Looks mostly good. I think you need to resolve this against the latest master for some reason. Hopefully then the PR build will work. |
The only conflict is because of FORMATS.md sigh. |
You can't resolve conflicts in github itself. You can just pull master into your branch again (resolve the conflict) and it should be fine. |
This adds support for Apple DART's RLE algorithm.
I've put it in its separate folder because DART implements another algorithm, a variation of LZH differently enough that no known implementation decodes it correctly.
Or maybe we should move DART's RLE/LZH, ADC, and in the future, KenCode, to a folder called "Apple"???
I also corrected the comments that contained incorrect copyright messages and filenames, and the Formats documentation.